Code Review
Folder: .github/skills/tsh-code-reviewing/
Used by: Code Reviewer
Provides a structured 9-step code review process covering correctness, quality, security, testing, and scalability.
9-Step Review Checklist
- Understand the task — Read research and plan files.
- Compare to plan — Verify implementation matches the plan.
- Review implementation — Check correctness, code quality, adherence to standards.
- Verify tests — Ensure critical paths are covered.
- Run tests — Execute test suite, verify passing.
- Best practices — Check SOLID, SRP, DDD, DRY, KISS principles.
- Static analysis — Run linters, formatters, type checks.
- Security — Validate against OWASP TOP10.
- Scalability — Assess horizontal scaling, statelessness, computational complexity.
Review Focus Areas
| Area | What It Covers |
|---|---|
| Correctness | Code functions as intended, meets requirements |
| Code Quality | Clean, efficient, maintainable, low cognitive complexity |
| Security | OWASP TOP10 validation, no vulnerabilities |
| Testing | Critical paths covered, tests pass |
| Scalability | Horizontal scaling, statelessness, Big O analysis |
| Acceptance Criteria | Each item from the plan verified individually |
Connected Skills
tsh-implementation-gap-analysing— Compare implementation against the plan.tsh-technical-context-discovering— Review against project conventions.tsh-sql-and-database-understanding— Review database-related code quality.